GoogleCloudPlatform / PerfKitExplorer

PerfKit Explorer is a dashboarding and performance analysis tool built with Google technologies and easily extensible. PerfKit Explorer is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.
Apache License 2.0
268 stars 64 forks source link

Add error messaging to pivot DuplicateValueError failures #270

Closed jmuharsky closed 8 years ago

jmuharsky commented 8 years ago

This resolves an issue where certain pivot errors were returning an empty string.

jmuharsky commented 8 years ago

Demo is at https://27-1-dot-perfkit-explorer.googleplex.com

ivansmf commented 8 years ago

I suggested a more actionable error message, could you please review?

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


ivansmf commented 8 years ago

Dear Googlebot, you're drunk, go home. https://g3doc.corp.google.com/company/teams/opensource/cla/index.md?cl=head#googlers

On Mon, Mar 28, 2016 at 5:59 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: :memo:] Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/GoogleCloudPlatform/PerfKitExplorer/pull/270#issuecomment-202649616

jmuharsky commented 8 years ago

Good otherwise? I updated the error message.