GoogleCloudPlatform / PerfKitExplorer

PerfKit Explorer is a dashboarding and performance analysis tool built with Google technologies and easily extensible. PerfKit Explorer is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.
Apache License 2.0
268 stars 64 forks source link

Fixes silent failure issues #273

Closed jmuharsky closed 8 years ago

jmuharsky commented 8 years ago

In cases where error messages aren't returning a string, Explorer is silently failing, and the widget will continue to appear in a loading state. This fixes the issue so that "An unexpected error occurred" appears if no error text is provided.

jmuharsky commented 8 years ago

Demo is at https://27-1-dot-perfkit-explorer.googleplex.com

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


jmuharsky commented 8 years ago

Cleaned up comments. PTAL?

jmuharsky commented 8 years ago

To the googlebot: I signed the CLA some time ago, and have been the major contributor to this repository for >1 year. Please verify the request.