GoogleCloudPlatform / active-assist

Apache License 2.0
24 stars 9 forks source link

`region` not being passed by Cloud Scheduler #11

Closed ryanaross closed 1 year ago

ryanaross commented 1 year ago

The main recommendations Workflow is expecting an input of region: https://github.com/GoogleCloudPlatform/active-assist/blob/883d8203f315371f2cc03c0f2ad43a4bd7b6ad26/remora-project-cleaner/terraform/modules/project-cleanup/workflows/recommendations_workflow_main.yaml#L47

But the Cloud Scheduler job is not sending this parameter: https://github.com/GoogleCloudPlatform/active-assist/blob/883d8203f315371f2cc03c0f2ad43a4bd7b6ad26/remora-project-cleaner/terraform/modules/project-cleanup/main.tf#L211

Before adjusting this, I was getting the following error:

RuntimeError: "Input region not specified."
in step "checkInput", routine "main", line: 46
"Input region not specified."
xiangwa commented 1 year ago

Thank you Ryan for flagging this! We're looking into it.