search

GoogleCloudPlatform / ai-on-gke

AI on GKE is a collection of examples, best-practices, and prebuilt solutions to help build, deploy, and scale AI Platforms on Google Kubernetes Engine
Apache License 2.0
222 stars 168 forks source link

Pin the terraform import paths on the release branch to the v1.1.2 release tag #639

Closed roberthbailey closed 5 months ago

imreddy13 commented 5 months ago

/gcbrun

roberthbailey commented 5 months ago

/gcbrun

imreddy13 commented 5 months ago

/gcbrun

roberthbailey commented 5 months ago

/gcbrun

roberthbailey commented 5 months ago

/gcbrun

imreddy13 commented 5 months ago

/gcbrun

roberthbailey commented 5 months ago

/gcbrun

roberthbailey commented 5 months ago

Actually got a more useful error this time:

AssertionError: unexpected response url: got http://127.0.0.1:9443/hub/login?_xsrf=MnwxOjB8MTA6MTcxNDYxNjM2MXw1Ol94c3JmfDY4OlRtOXVaVHB3WlZGeE9VSm5TVlJTVm1WQmFVSnZjR2d4VVRWU2FWQmZiWGxJVGw5QmJuVTNja05pUkU4eE1rbFpQUT09fDcwNThmOTM3ZmM0M2JlY2MxMjQzZjQ5MTBhZjk5Mjk0NGYxZWYyNTRlMjY5ODg0MmQ5OTE2MDdjZTI3ZTE0M2M, expected http://127.0.0.1:9443/hub/spawn
roberthbailey commented 5 months ago

I saw this while I was testing https://github.com/GoogleCloudPlatform/ai-on-gke/pull/643 - it happened when the credentials supplied to the query were incorrect.

roberthbailey commented 5 months ago

The failing test reads the username and password from a local file loaded from a relative path (https://github.com/GoogleCloudPlatform/ai-on-gke/blob/main/modules/jupyter/tests/test_hub.py#L7). I'm wondering if something about loading modules remotely from github vs. using modules at relative paths is preventing this file from having the proper credentials set.

I'm going to abandon this proposed change for now, but wanted to leave some thoughts in case we come back and try to fix this for future releases.