GoogleCloudPlatform / ai-on-gke

AI on GKE is a collection of examples, best-practices, and prebuilt solutions to help build, deploy, and scale AI Platforms on Google Kubernetes Engine
Apache License 2.0
211 stars 154 forks source link

Simplify how default values are set for complex variables types. #728

Open roberthbailey opened 2 months ago

roberthbailey commented 2 months ago

As documented in https://developer.hashicorp.com/terraform/language/expressions/type-constraints#optional-object-type-attributes

"Terraform applies the default value you specify in the optional modifier first and then later applies any nested default values to that attribute"

which means that the values specified in "optional" constraints was always overridden immediately by the defaults specified below.

This change simplifies how the defaults are set, solely using the optional defaults.

roberthbailey commented 2 months ago

/gcbrun