search

GoogleCloudPlatform / alloydb-python-connector

A Python library for connecting securely to your AlloyDB instances.
Apache License 2.0
28 stars 7 forks source link

Connector: refresh token if needed before metadata exchange. #347

Closed xjuan closed 1 month ago

xjuan commented 1 month ago

Fix issue #346 "Invalid token in metadata exchange"

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

enocom commented 1 month ago

Thanks for the PR @xjuan. Before we can look at this, we need you to sign the CLA.

See here for details: https://github.com/GoogleCloudPlatform/alloydb-python-connector/pull/347/checks?check_run_id=27567309191

xjuan commented 1 month ago

Hi the CLA was submitted my the CTO, not sure if it should refresh automatically or not

enocom commented 1 month ago

If look at https://github.com/GoogleCloudPlatform/alloydb-python-connector/pull/347/checks?check_run_id=27633672198, it will let you re-run the scan. I think right now the commit has a personal and a company email which is causing it to still fail.

enocom commented 1 month ago

We'd like to get this bug fixed and in a release ASAP. Thanks again for the issue @xjuan!

enocom commented 1 month ago

Replaced by https://github.com/GoogleCloudPlatform/alloydb-python-connector/pull/351.

xjuan commented 1 month ago

hi, sorry I was in a conference, thanks for taking care of this.

enocom commented 1 month ago

No problem. Thanks for the issue. On further digging we found the root cause (this was just a symptom): https://github.com/GoogleCloudPlatform/alloydb-python-connector/issues/357.

enocom commented 1 month ago

That's also been fixed in the latest release.