search

GoogleCloudPlatform / android-docs-samples

Apache License 2.0
373 stars 594 forks source link

Add a sample for Natural Language API #1

Closed yaraki closed 8 years ago

jfschmakeit commented 8 years ago

Generally LGTM from the Android side, just a few small nits.

Please also add an introductory message, that comes up when the app is loaded and doesn't have any data yet. On a hardware keyboard (ie. Pixel C.), pressing ENTER should also fire off a request, I have added a comment to the code as well.

For the "Syntax" tab, I wonder if you could use the flexbox layout, the list looks a bit sparse on a tablet. This is just a UI nit though.

yaraki commented 8 years ago

Using FlexboxLayout is a brilliant idea.

frankyn commented 8 years ago

LGTM: Works as expected. Tested app on an Android Device and Android Studio Emulator.

yaraki commented 8 years ago

Thanks! I'm merging this in.

puneith commented 8 years ago

Thanks Frank for verifying! LGTM.

tayhengee commented 6 years ago

I'm facing a problem here to replace the service account with end user credential (Firebase), how do I fix it?