Integration Firebase Functions

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

nnegrey commented 4 years ago

Oh I forgot about this one, we need to add the LICENSE to the top of the java files.

/*
 * Copyright 2019 Google LLC
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

nnegrey commented 4 years ago

I think my last 2 big things are: 1) If you can easily switch over to the streaming audio call for Dialogflow so as the user is speaking the audio is sent. 2) Take the really long lines and just make them multi line for code readability. Example: From 223 columns.

    private DetectIntentRequest getDetectIntentRequest(SessionName sessionName, QueryInput queryInput,boolean tts, boolean sentiment, boolean knowledge, FixedCredentialsProvider fixedCredentialsProvider) throws Exception {

To something under 100 columns.

    private DetectIntentRequest getDetectIntentRequest(
            SessionName sessionName, QueryInput queryInput,boolean tts, boolean sentiment,
            boolean knowledge, FixedCredentialsProvider fixedCredentialsProvider) throws Exception {

bdannoville commented 4 years ago

Hi there, please note that at lign 50 of the readme, the link to the index.js containing nodeJS cloud functions for Dialogflow is broken. This file doesn't exist in the targeted github project: GoogleCloudPlatform/nodejs-docs-samples.

nnegrey commented 4 years ago

Updated link should be: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/functions/tokenservice/functions/index.js

nnegrey commented 4 years ago

Samples moved into multiple PRs: https://github.com/GoogleCloudPlatform/android-docs-samples/pull/112 https://github.com/GoogleCloudPlatform/android-docs-samples/pull/113

Closing.

GoogleCloudPlatform / android-docs-samples