search

GoogleCloudPlatform / android-docs-samples

Apache License 2.0
375 stars 596 forks source link

Dialogflow sample #112

Closed nnegrey closed 4 years ago

nnegrey commented 4 years ago

Breaking multiple samples into individual PRs. https://github.com/GoogleCloudPlatform/android-docs-samples/pull/108

googlebot commented 4 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

nnegrey commented 4 years ago

Kokoro Error: "File google-services.json is missing. The Google Services Plugin cannot function without it."

Since Android Studio now requires it to build the app, not sure how to get around this one.

frankyn commented 4 years ago

@nnegrey I might not be the right person to review this PR.

If the google-services.json is similar to a service account (I haven't taken a look). Take a look at this helper Groovy function.

https://github.com/GoogleCloudPlatform/android-docs-samples/blob/30784ed1560b4232b7131d40df44a7a6018f2eb1/nl/LanguageClient/app/build.gradle#L60-L67

googlebot commented 4 years ago

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.