Closed rishavjalan closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it! :)
CLAs look good, thanks!
@frankyn could you review this and this to the repo as I believe it might help others in testing the word offsets with the sample code on the documentation website.
So there's good news and bad news.
:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google
commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
Yeah its fine
On 6 Nov 2017 13:16, "googlebot" notifications@github.com wrote:
So there's good news and bad news.
👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/android-docs-samples/pull/44#issuecomment-342289360, or mute the thread https://github.com/notifications/unsubscribe-auth/AEdsUHDRgcxvDaBX0Wv9lQoa3GNOfv2Cks5sz3cfgaJpZM4PWC4p .
@kurtisvg how long does it take for Kokoro to complete tests?
@frankyn Since the original author is outside of the GoogleCloudPlatform organization, Kokoro will not queue the job automatically. Instead, you'll need to apply the kokoro:run
label to this PR after vetting the code.
@kurtisvg Thank you!
@kurtisvg by chance do you know why Kokoro Team automatically removes the label? I see that Kokoro CI started so I'm guessing it removes after it starts the build.
@frankyn Yes, it removes it once the job is queued so you know it's started.
Fixed Kokoro CI not running tests in #55. Waiting on build status before merge.
Thanks @rishavjalan, apologies for the delay.
Kokoro says this is a problem.
Changes include: Changelist https://github.com/GoogleCloudPlatform/android-docs-samples/commit/1027e01b5dd2cd47a52d86a939ef97a1593dc155 by Rishav Jalan: updated speech proto file to enable word offsets (#44)
Not sure why.
The periodic test failed for some reason, and this is just the last commit on that branch. It's probably a flaky test somewhere and unrelated to the commit, because it's passed the periodic test dozens of times previously.
@lesv and @kurtisvg, looks like it was only a flake. It had to do with Firebase Testlab failure with legacy EP Android app.
From googleapis repository