search

GoogleCloudPlatform / anthos-samples

Anthos code samples
https://cloud.google.com/anthos/docs
Apache License 2.0
93 stars 119 forks source link

The gke.googleapis.com labels are set on the wrong level for systemd #98

Open jiwang576 opened 2 years ago

jiwang576 commented 2 years ago

There should be an extra nest plugin to nest them under "logging.googleapis.com". Maybe we should consider move it to filter-kubernetes.conf so it can be effective for all included files.

https://github.com/GoogleCloudPlatform/anthos-samples/blob/1da0132772f43655ef97e54841de755f143b394d/aws-logging-monitoring/logging/forwarder.yaml#L203

[FILTER]
        # https://docs.fluentbit.io/manual/filter/nest
        Name    nest
        Match   *
        Operation nest
        Wildcard gke.googleapis.com*
        Nest_under logging.googleapis.com/labels
charlieyu1996 commented 2 years ago

Tagging @GoogleCloudPlatform/onyx-gke-observability team since they own /aws-logging-monitoring/ . Can the team PTAL at this?

Shabirmean commented 1 year ago

@erain @rsgowman @leonzz - any thoughts on this issue?

erain commented 1 year ago

I didn't know this repo is still in use. @jiwang576 please feel free to create a PR