search

GoogleCloudPlatform / anthos-service-mesh-packages

Packaged configuration for setting up a Kubernetes cluster with Anthos Service Mesh features enabled
https://cloud.google.com/anthos/service-mesh
Apache License 2.0
134 stars 169 forks source link

This detection seems to miss our service account because for format is different #630

Closed matthewkrupnik closed 3 years ago

matthewkrupnik commented 3 years ago

A check if the current account is a service account is failing for us. Our build in CloudBuild is running under the default service account (xxxxxxxx@cloudbuild.gserviceaccount.com), which is a service account but does not match the check. https://github.com/GoogleCloudPlatform/anthos-service-mesh-packages/blob/1fa84c122f33afcc966689c66d96168150658abb/scripts/asm-installer/install_asm#L1838

I think the check should be changed to a more broad version: if is_sa || [[ "${ACCOUNT_NAME}" = *.gserviceaccount.com ]]; then

matthewkrupnik commented 3 years ago

Now that PR https://github.com/GoogleCloudPlatform/anthos-service-mesh-packages/pull/631 is merged, I've tested the updated script and it works for us. Thanks @zerobfd! Closing this issue