GoogleCloudPlatform / anthos-service-mesh-packages

Packaged configuration for setting up a Kubernetes cluster with Anthos Service Mesh features enabled
https://cloud.google.com/anthos/service-mesh
Apache License 2.0
134 stars 169 forks source link

install_asm uses kpt binary for ARM (M1) per default for darwin #789

Open danistrebel opened 3 years ago

danistrebel commented 3 years ago

The ASM installer for kpt uses the arm binary per default.

https://github.com/GoogleCloudPlatform/anthos-service-mesh-packages/blob/master/scripts/asm-installer/install_asm#L1556

As a large number of Mac users would still be using an amd64 CPU the installer should pick correctly between the two architectures.

zerobfd commented 3 years ago

That's a great point. I only noticed the ARM build when I looked the first time. I'll get that fixed soon.