search

GoogleCloudPlatform / app-gradle-plugin

The library has moved to https://github.com/GoogleCloudPlatform/appengine-plugins/tree/main/app-gradle-plugin
Apache License 2.0
153 stars 40 forks source link

Added ability to configure Environment explicitly - #125 #126

Closed xSAVIKx closed 7 years ago

xSAVIKx commented 7 years ago

There is now an option to configure environment that would be used by app-gradle plugin explicitly using following syntax:

appengine{
  environment = ['standard'|'flexible']
}

If no environment was supplied fallback to the previous behaviour would be used. If environment doesn't match the values above configuration exception would be thrown as environment is an enum.

loosebazooka commented 7 years ago

Thanks for your contribution, but I don't think this would be the right way to do this. We will be allowing users to bypass auto-detection by allowing them to explicitly apply an appengine-standard or appengine-flexible plugin.

For now if you want to explicitly apply a plugin, you can do so using the class directly as described in #125

xSAVIKx commented 7 years ago

@loosebazooka got it. I'll just close this PR.