search

GoogleCloudPlatform / app-gradle-plugin

The library has moved to https://github.com/GoogleCloudPlatform/appengine-plugins/tree/main/app-gradle-plugin
Apache License 2.0
153 stars 40 forks source link

Avoid modifying CloudSdkBuilderFactory properties within task execution #216

Closed TadCordle closed 6 years ago

TadCordle commented 6 years ago

Home directory is updated after downloadCloudSdk task execution. Instead, it should probably be set in the configuration phase. This means the ManagedCloudSdk can be instantiated outside of the task as well, so the ManagedCloudSdkFactory instance doesn't need to be passed around.