GoogleCloudPlatform / app-gradle-plugin

The library has moved to https://github.com/GoogleCloudPlatform/appengine-plugins/tree/main/app-gradle-plugin
Apache License 2.0
153 stars 40 forks source link

Link to relevant configuration sections #443

Closed TWiStErRob closed 1 year ago

emmileaf commented 1 year ago

The failing check here is from a configuration update in the CI environment - could you rebase this off the latest fix in the main branch? Thanks!

TWiStErRob commented 1 year ago

There should be a rebase button on the PR...

TWiStErRob commented 1 year ago

Done, but please enable rebase updates on PRs... image it "only" replaces this task:

> git clone https://github.com/GoogleCloudPlatform/app-gradle-plugin

> git branch -a
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/patch-1

> git remote add up https://github.com/GoogleCloudPlatform/app-gradle-plugin

> git fetch up
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Total 4 (delta 3), reused 3 (delta 3), pack-reused 0
Unpacking objects: 100% (4/4), 931 bytes | 62.00 KiB/s, done.
From https://github.com/GoogleCloudPlatform/app-gradle-plugin
 * [new branch]      master                -> up/master

> git checkout patch-1
Switched to a new branch 'patch-1'
branch 'patch-1' set up to track 'origin/patch-1'.

> git rebase -i up/master
Successfully rebased and updated refs/heads/patch-1.

> git status
On branch patch-1
Your branch and 'origin/patch-1' have diverged,
and have 2 and 1 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

nothing to commit, working tree clean

> git push -f
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.

> cd ..
> rm -rf app-gradle-plugin

I think the setting is called: "Always suggest updating pull request branches", but there might be another factor.