search

GoogleCloudPlatform / app-gradle-plugin

The library has moved to https://github.com/GoogleCloudPlatform/appengine-plugins/tree/main/app-gradle-plugin
Apache License 2.0
153 stars 40 forks source link

Question: What is the minimum supported Gradle version? #450

Closed TWiStErRob closed 1 year ago

TWiStErRob commented 1 year ago

The repository sources are misleading:

https://github.com/GoogleCloudPlatform/app-gradle-plugin/blob/1d3084f175450d4a8188317092206737a4878e15/README.md?plain=1#L14

https://github.com/GoogleCloudPlatform/app-gradle-plugin/blob/1d3084f175450d4a8188317092206737a4878e15/src/main/java/com/google/cloud/tools/gradle/appengine/AppEnginePlugin.java#L37

https://github.com/GoogleCloudPlatform/app-gradle-plugin/blob/1d3084f175450d4a8188317092206737a4878e15/src/main/java/com/google/cloud/tools/gradle/appengine/core/AppEngineCorePluginConfiguration.java#L35

emmileaf commented 1 year ago

Thank you for catching this - I believe the README has the intended version compatibility here, and we likely missed updating GRADLE_MIN_VERSION used in the enforcement check and test suite. Will put in a PR for aligning them. (This may also need to be re-visited after #451, as you noted.)

TWiStErRob commented 1 year ago

@emmileaf thanks. Implementation-wise I would actually merge #451 first, and then move the constant to GradleCompatibility class so there's only one, not two of them.

emmileaf commented 1 year ago

Implementation-wise I would actually merge #451 first, and then move the constant to GradleCompatibility class so there's only one, not two of them.

That's a good suggestion - I'll unlink #453 and leave this issue open to track follow-ups needed.