Split into multiple plugins

GoogleCloudPlatform / app-gradle-plugin

The library has moved to https://github.com/GoogleCloudPlatform/appengine-plugins/tree/main/app-gradle-plugin

Apache License 2.0

153 stars 40 forks source link

Split into multiple plugins #74

Closed loosebazooka closed 7 years ago

loosebazooka commented 8 years ago

App Engine Plugin (Decider, Applyable)
App Engine Core Plugin (has deploy and defines the "appengine" extension, and "deploy")
Standard Plugin (has stage and run for standard apps)
Flexible Plugin (has stage for flex apps) ~- Source Context Plugin (Applyable)~ moved to another CL

This change also changes how extensions are created. Using nested extensions instead of evaluation closures.

loosebazooka commented 8 years ago

@meltsufin @patflynn

I really really apologize for this, but when writing the SourceContext Plugin, there wasn't a good way to really apply it nicely. I decided to split the plugins out.

Most of the new code is in "com.google.cloud.tools.gradle.appengine.sourcecontext" and everything else is just moving a bunch of stuff around.

The mechanism for instantiating extensions changed a little. Testing seems to think it's okay. In the end, the public API hasn't changed, so people don't need to change their build files.

loosebazooka commented 8 years ago

Also if this review is annoying or painful, I can pull out the sourcecontext stuff and add it to a follow up PR.

loosebazooka commented 8 years ago

moved source context out of this PR into another one.