search

GoogleCloudPlatform / app-maven-plugin

The library has moved to https://github.com/GoogleCloudPlatform/appengine-plugins/tree/main/app-maven-plugin
Apache License 2.0
102 stars 42 forks source link

Support and Test JDK17 #453

Closed grant closed 2 years ago

grant commented 2 years ago

Expected

JDK 17 reached General Availability on 14 September 2021. This repo should test JDK 17.

Actual

JDK 17 is not tested. Just 8 and 11:

https://github.com/GoogleCloudPlatform/app-maven-plugin/blob/master/.github/workflows/unit-tests.yaml

ludoch commented 2 years ago

FYI, GAE Java17 is currently in the work. https://github.com/GoogleCloudPlatform/buildpacks/tree/e1dfd783f710dae1b74ba16ddd3b769218b50982/builders/gae/java17 including gen1 GAE API standard support.

mpeddada1 commented 2 years ago

Thank you for filing the issue @grant and the additional details on GAE Java 17 support @ludoch! Yes, it'll be good to check if this works without the need for any additional changes for the maven plugin.

grant commented 2 years ago

Thanks. For reference, Java 17 support is a P0 OKR for serverless runtimes. I'll be monitoring this repo and other dependencies.

grant commented 2 years ago

Sync'd on this issue on VC. FYI I won't be blocked on anything here but we can keep track of notes here. There may be some common dependencies that need updating.

Will file issues as I come across them.

ludoch commented 2 years ago

Any update on progress?

elefeint commented 2 years ago

Sync'ed offline; we will look into Java 17 compatibility in both Maven and Gradle plugins.

elefeint commented 2 years ago

This was done for runtime compatibility for both maven and gradle plugins. The maven portion was in #455 and #456. The last bit for local devserver was done by pulling in appengine-plugins-core 0.9.9.

ludoch commented 2 years ago

Thank you!