search

GoogleCloudPlatform / appengine-gcs-client

App Engine-Cloud Storage custom client library
Apache License 2.0
124 stars 112 forks source link

Removed application: and version: elements #45

Closed RichieEscarez closed 8 years ago

RichieEscarez commented 8 years ago

Updating tutorial to instead use gcloud app deploy, which does not support the application: and version: elements in app.yaml files (command will fail with errors)

RichieEscarez commented 8 years ago

Ping.

Can someone please help merge these changes?

Users who attempt to complete this tutorial will run into errors due to the application: and version: elements in app.yaml file.

aozarov commented 8 years ago

Does it work for Java? Even if it does (then I assume we just ignore the app/version in the appengine-web.xml) shouldn't we remove it for consistency/clarity?

RichieEscarez commented 8 years ago

Java does not yet support gcloud app deploy so from what I know, no leave the appengine-web.xml file as it is with 'application' and 'version' elements (right now, only Python and PHP support gcloud app deploy).

aozarov commented 8 years ago

Though Java does not support deployment via the cloud SDK CLI it actually does use it via the maven plugin. That one transforms appengine-web.xml to app.yaml and will complain if it sees the application/version (and at some point will fail).

Currently Cloud SDK environment is picked before the values from the xml and therefore I think fixing it for Java as well is safe. However, I guess it would be fine to do it later (but before the plugin would start failing on it).