Initialize HttpChannel in DelegateConnection to create Violation Listeners

GoogleCloudPlatform / appengine-java-standard

Google App Engine Standard Java runtime: Prod runtime, local devappserver, Cloud SDK Java components, GAE APIs, and GAE API emulators.

Apache License 2.0

197 stars 45 forks source link

Initialize HttpChannel in DelegateConnection to create Violation Listeners #260

Closed lachlan-roberts closed 3 months ago

lachlan-roberts commented 3 months ago

The DelegateConnection is missing a call to initialize the HttpChannel this is necessary to create the violation listeners. Currently violations reported will cause NPE as the listener has not been set.

ludoch commented 3 months ago

related to internal bug 359557991

ludoch commented 3 months ago

Probeapp.java running for java21 should have detected it, but our internal prober has an issue unrelated for that.