ensure flushOnResponseCommit is true for session caches

GoogleCloudPlatform / appengine-java-standard

Google App Engine Standard Java runtime: Prod runtime, local devappserver, Cloud SDK Java components, GAE APIs, and GAE API emulators.

Apache License 2.0

197 stars 45 forks source link

ensure flushOnResponseCommit is true for session caches #267

Closed lachlan-roberts closed 2 months ago

lachlan-roberts commented 2 months ago

Ensure that the FlushOnResponseCommit setting is set to true for the GAE SessionCaches. This configuration was suggested by @janbartel.

If true, a dirty session will be written to the SessionDataStore just before a response is returned to the client. This ensures that subsequent requests to either the same node or a different node see the changed session data.

ludoch commented 2 months ago

I redeployed the QA probers for all runtimes, and it seems OK now. Still not 100% sure this is it because it used to work before, but QA is green with this and the sessions test. Thanks!