Create /var/log/app_engine directory #313

GoogleCloudPlatform / appengine-java-vm-runtime

Apache License 2.0

67 stars 34 forks source link

Create /var/log/app_engine directory #313 #315

Closed gregw closed 8 years ago

gregw commented 8 years ago

Create /var/log/app_engine directory #313

meltsufin commented 8 years ago

LGTM

ludoch commented 8 years ago

What is the side effect on Compat, (or even flex) where I think this directory path is provided as a Docker volume? Someone has to check this PR on a real image for both pure openjdk and compat...

meltsufin commented 8 years ago

That's a good point. The issue was raised based on a local run of the image without mounting the logs volume, but if the volume is always mounted when the App Engine run the image, it may not be an actual issue. We just need to fix the README to instruct mounting of the logs volume.

gregw commented 8 years ago

no longer required