search

GoogleCloudPlatform / appengine-maven-archetypes-java

App Engine Maven Archetypes
Apache License 2.0
16 stars 20 forks source link

nbactions.xml in guestbook-example needs to be fixed or removed #48

Closed chanseokoh closed 7 years ago

chanseokoh commented 7 years ago

The goals in nbactions.xml are the old plugin goals:

https://github.com/GoogleCloudPlatform/appengine-maven-archetypes-java/blob/master/guestbook-archetype/src/main/resources/archetype-resources/nbactions.xml#L7

lesv commented 7 years ago

Ah - Agree - they need to be dynamic as well.

lesv commented 7 years ago

@elharo / @chanseokoh Do you use the eclipse-launch-profiles? And do you care that they are correct?

elharo commented 7 years ago

Haven't checked, but I doubt these are necessary if Cloud Tools for Eclipse is installed. They might be useful if it isn't.

elharo commented 7 years ago

Just checked. Definitely not needed if CT4E is installed.

elharo commented 7 years ago

And if CT4E isn't installed they still don't seem to do anything. Delete them.

lesv commented 7 years ago

63 fixes