GoogleCloudPlatform / appengine-maven-archetypes-java

App Engine Maven Archetypes
Apache License 2.0
16 stars 20 forks source link

Update endpoints archetypes with new tooling #54

Closed frankyn closed 7 years ago

frankyn commented 7 years ago
frankyn commented 7 years ago

@lesv PTAL

  1. Acknowledging comments.
  2. Adding a test to verify specific deployed version versus a prior deployment.
  3. Updated static pom values
    <groupId>com.example.helloendpoints</groupId>
    <artifactId>helloendpoints</artifactId>
  4. Updated Copyrights to be Velocity comments
  5. Updated README.md to reflect our conversation.
  6. Added e2e test to Jenkins
lesv commented 7 years ago

So the same comments I gave about the sample should apply here, except, of course, the parent pom doesn't appear in the generated code. (Nor do we have copyrights).

frankyn commented 7 years ago

@Les, I modified archetypes to use velocity comments as suggested from a prior meeting. Do you want to remove copyright headers from the archetypes?

frankyn commented 7 years ago

@lesv PTAL