GoogleCloudPlatform / appengine-maven-plugin

Automatically exported from code.google.com/p/appengine-maven-plugin
Apache License 2.0
19 stars 21 forks source link

gcloud_app_deploy fails when gcloud_directory not set. #58

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Ensure that gcloud_directory is not set
2. $ mvn [...] appengine:gcloud_app_deploy

What is the expected output? What do you see instead?
Deployment. "Build Failure"

What version of the product are you using? On what operating system?
appengine-maven-plugin v1.9.9

Please provide any additional information below.

The if-else logic for a null gcloud_directory parameter[1] is incomplete.

A gcloud string is set for the default location[2], but there is no 
corresponding devAppServerCommand.add(gcloud).

1. 
https://code.google.com/p/appengine-maven-plugin/source/browse/src/main/java/com
/google/appengine/gcloudapp/GCloudAppDeploy.java#156

2. 
https://code.google.com/p/appengine-maven-plugin/source/browse/src/main/java/com
/google/appengine/gcloudapp/GCloudAppDeploy.java#159

Original issue reported on code.google.com by david....@inclusiq.com on 19 Aug 2014 at 1:49