search

GoogleCloudPlatform / appengine-php-sdk

Google App Engine PHP SDK
Apache License 2.0
29 stars 33 forks source link

Update env variables in AppIdentity #75

Closed zachluna closed 3 years ago

zachluna commented 3 years ago

Update env variables to use PHP7 compatible variables. PHP7 Variables: https://cloud.google.com/appengine/docs/standard/php7/runtime#environment_variables PHP5 Variables: https://cloud.google.com/appengine/docs/standard/php/runtime#environment_variables

zachluna commented 3 years ago

It seems hard to detect this type of issues through unit tests. Handling environment variables is a primary source of bugs. I'm curious about how you spot this bug. Also, are we confident that these env vars are complete?

Yes it is not fully testable in the unit tests. As far as Env Vars in AppIdentity, I have replaced all of the Env Vars which exist in AppIdentity, so it is a complete list. I found this via the mail integration test (still in development) which uses this api.