search

GoogleCloudPlatform / appengine-php-sdk

Google App Engine PHP SDK
Apache License 2.0
29 stars 33 forks source link

ApiProxy - implementation change for http requests #76

Closed zachluna closed 3 years ago

zachluna commented 3 years ago
  1. Change ApiProxy and unit tests from being streamwrapper based to using GuzzleHttp\Client which is curl based. This resolve conflict with APIs that use streamwrappers such as UrlFetch.
  2. Change headers in UrlFetchStream headers to be public to enable reading and verifying successful header responses in tests/code.
zachluna commented 3 years ago

I think this whole VmApiProxy is not used any more (at least the same way as it was intended for). Could you investigate a little bit more about how it's being used today?

  • I'm sharing a shortn link to avoid exposing our base base to the public. http://shortn/_XVRF11VCaz says it's used for service bridge.
  • Service bridge is no longer used by VmRuntimes. See a design I wrote in 2018 :) go/service-bridge-https

I have now converted VmApiProxy to RealApiProxy (and deprecated the prior RealApiProxy). Thanks for pointing this out!