search

GoogleCloudPlatform / appengine-plugins

A client Java library to manage App Engine Java applications for any project that performs App Engine Java application management. For example, the Maven, Gradle and Eclipse App Engine plugins, custom user tools, etc.
Apache License 2.0
40 stars 26 forks source link

Support Java 17 runtime #881

Closed colorizenl closed 2 years ago

colorizenl commented 2 years ago

According to your own documentation, Java 17 is now supported in the App Engine Standard Environment.

However, the Gradle plugin did not accept the runtime: java17 value in app.yaml.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

clementdenis commented 2 years ago

I have a slightly more future-proof version of the same: https://github.com/GoogleCloudPlatform/appengine-plugins-core/compare/master...clementdenis:master

I also need this for the Maven plugin.

ludoch commented 2 years ago

Thanks, both versions would work. LGTM.

colorizenl commented 2 years ago

Sorry for the late reply, I updated the test.

elefeint commented 2 years ago

@colorizenl Thank you!