GoogleCloudPlatform / appengine-plugins

A client Java library to manage App Engine Java applications for any project that performs App Engine Java application management. For example, the Maven, Gradle and Eclipse App Engine plugins, custom user tools, etc.
Apache License 2.0
36 stars 25 forks source link

chore: Allow custom JDK version for Dev Server #917

Closed lqiu96 closed 1 year ago

lqiu96 commented 1 year ago

Thank you for your interest in contributing! For general guidelines, please refer to the contributing guide.

Before submitting a pull request, please make sure to:

Allow users to allow a pass in the JDK version as part of the DevServer's Run Configurations. This may be different from the JDK specified in JAVA_HOME. By default, this plugin should generally be using the java.specification.version System Property. If needed, customers can use the Run Configuration's JDK version to override.

Fixes #916 🛠️

lqiu96 commented 1 year ago

@blakeli0 @suztomo Can you give this PR an initial review? Talked with Etan and I think this approach is simple enough to allow customization and fix their issue.

suztomo commented 1 year ago

Few nice-to-fixes.

lqiu96 commented 1 year ago

Setting automerge and will release once checks are green.