search

GoogleCloudPlatform / appengine-plugins

A client Java library to manage App Engine Java applications for any project that performs App Engine Java application management. For example, the Maven, Gradle and Eclipse App Engine plugins, custom user tools, etc.
Apache License 2.0
36 stars 25 forks source link

[do not merge] check adding -E flag in build script #919

Closed emmileaf closed 1 year ago

emmileaf commented 1 year ago

For troubleshooting release script / Kokoro environment compatibility

emmileaf commented 1 year ago

FYI @lqiu96 - let's see if the kokoro-ubuntu check gets stuck on the same issue as the release script?

lqiu96 commented 1 year ago

FYI @lqiu96 - let's see if the kokoro-ubuntu check gets stuck on the same issue as the release script?

Thanks @emmileaf. I think kokoro-ubuntu runs the this job: https://github.com/GoogleCloudPlatform/appengine-plugins-core/blob/master/kokoro/continuous.sh, right? The PR I just submitted passed that CI job so I think it's probably the additional -E flags in the release script causing the issue.

lqiu96 commented 1 year ago

Not entirely sure why it was added in the first place or why it was only added to only the release job. I'll do a bit of digging before I just remove this flag.

lqiu96 commented 1 year ago

Ok, nvm. I misunderstood the PR. This still passes even with the -E flag added into the continuous script. That's odd...

emmileaf commented 1 year ago

This still passes even with the -E flag added into the continuous script. That's odd...

Yeah this is just a sanity check to see if the issue can be reproduced on the continuous script, but seems not...could it have been a one-time/transient thing?

lqiu96 commented 1 year ago

This still passes even with the -E flag added into the continuous script. That's odd...

Yeah this is just a sanity check to see if the issue can be reproduced on the continuous script, but seems not...could it have been a one-time/transient thing?

Tried re-running the job and it's the same issue. Stuck waiting for user input unfortunately.