search

GoogleCloudPlatform / appengine-plugins

A client Java library to manage App Engine Java applications for any project that performs App Engine Java application management. For example, the Maven, Gradle and Eclipse App Engine plugins, custom user tools, etc.
Apache License 2.0
36 stars 25 forks source link

chore: Update mvn wrapper files #923

Closed lqiu96 closed 1 year ago

lqiu96 commented 1 year ago

Copy spring-cloud-gcp's .mvn folder and mvnw files. Only contains the files that the spring repo uses.

Issue:

+ ./mvnw -Prelease -B -U verify
--2023-04-28 16:45:38--  https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.4.2/maven-wrapper-0.4.2.jar
Resolving repo.maven.apache.org (repo.maven.apache.org)... 151.101.0.215, 151.101.64.215, 151.101.128.215, ...
Connecting to repo.maven.apache.org (repo.maven.apache.org)|151.101.0.215|:443... connected.
ERROR: cannot verify repo.maven.apache.org's certificate, issued by 'CN=Build Proxy,O=Google LLC,L=New York City,C=US':
  Self-signed certificate encountered.
To connect to repo.maven.apache.org insecurely, use `--no-check-certificate'.
Picked up JAVA_TOOL_OPTIONS: '-Djavax.net.ssl.trustStore=/var/cache/proxy.crt.jks'
[0.008s][warning][os,container] Duplicate cpuset controllers detected. Picking /sys/fs/cgroup/cpuset, skipping /tmpfs/docker/overlay2/1edd4811d515252345e2b43fe3a1b3d66b39c0c90993273b39aeebd20f16bed7/merged/sys/fs/cgroup/cpuset.
Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain
Caused by: java.lang.ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain
lqiu96 commented 1 year ago

This does remove the .mvn/wrapper/MavenWrapperDownloader.java file. Spring doesn't have this file and is able to release properly.

emmileaf commented 1 year ago

Spring doesn't have this file and is able to release properly.

@lqiu96 IIRC spring-cloud-gcp ran into an issue with using maven wrapper in the release script, and actually uses mvn for release now (ref).

Maybe we could try updating the maven wrapper in this repo with mvn wrapper:wrapper, or check if switching to mvn instead of ./mvnw can unblock the release script instead?

lqiu96 commented 1 year ago

Ah ok, thanks for the info! Hmm, let me try and keep the spring repo's files. I'll update the release script to use mvn instead of ./mvnw and try a release. WDYT?

emmileaf commented 1 year ago

Worth a try!

lqiu96 commented 1 year ago

Ok, I created another PR with the mvnw -> mvn change (https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/924). Opened it up to start the CI since it takes a while. Let's see the results