GoogleCloudPlatform / appengine-ruby

Optional integration library for the Ruby runtime for Google App Engine
Apache License 2.0
53 stars 21 forks source link

Gcloud.rb file made windows compatible #9

Closed gokaykucuk closed 7 years ago

gokaykucuk commented 7 years ago

I tried to follow the tutorial at https://cloud.google.com/ruby/rails/using-cloudsql-postgres but appengine gem failed on windows. I've made some changes to make it work, hopefully not broke anything on nix environments :)

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


gokaykucuk commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

dazuma commented 7 years ago

@gkaykck Your change is now in the 0.4.4 gem release. Thanks again!