search

GoogleCloudPlatform / application-integration-management-toolkit

This tool lets you interact with Application Integration, Integration Connectors or Apigee Integration/Connector APIs. The tool lets you manage (create, del, get, list) integrations, connections etc.
Apache License 2.0
22 stars 16 forks source link

feat: Allow to skip authconfigs by scaffolding too #254 #255

Closed teliatko closed 3 months ago

teliatko commented 3 months ago

This PR solves #254, by adding --skip-authconfigs into scaffold command.

I also changed docs and for symmetry adapted also apply command.

Please let me know your opinion.

Btw. just subtle suggestion in Google Integration the authconfigs are called "auth profiles", at least in GCP web console menu. Maybe it will be worth to have consistent naming in CLI tool like this. I know that naming here is inspired by REST API, but anyway it is confusing.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

teliatko commented 3 months ago

All the docs are auto generated. Please don't change the docs.

Rolled back, sorry.

teliatko commented 3 months ago

@srinandan btw. how the CLA works. I filled it already but in UI at https://cla.developers.google.com/clas I still don't see that it is signed.

ssvaidyanathan commented 3 months ago

@teliatko - make sure you are using the same email id (te****ko​@gmail.com) in https://cla.developers.google.com/

teliatko commented 3 months ago

@teliatko - make sure you are using the same email id (te****ko​@gmail.com) in https://cla.developers.google.com/

Just checked, I'm 100% sure that the email is correct.

ssvaidyanathan commented 3 months ago

@teliatko - looks like the CLA is successful now.