search

GoogleCloudPlatform / artifact-registry-apt-transport

Apache License 2.0
9 stars 15 forks source link

add apt method #1

Closed hopkiw closed 3 years ago

illfelder commented 3 years ago

@adjackura Can you please take a look?

hopkiw commented 3 years ago

/cc zoran15

hopkiw commented 3 years ago

haven't set up presubmit on this repo yet, so test output:

+>>> go test -v
=== RUN   TestAptMessageGet
--- PASS: TestAptMessageGet (0.00s)
=== RUN   TestAptWriterWriteMessage
--- PASS: TestAptWriterWriteMessage (0.00s)
=== RUN   TestAptWriterSendCapabilities
--- PASS: TestAptWriterSendCapabilities (0.00s)
=== RUN   TestAptWriterLog
--- PASS: TestAptWriterLog (0.00s)
=== RUN   TestAptWriterURIStart
--- PASS: TestAptWriterURIStart (0.00s)
=== RUN   TestAptWriterURIDone
--- PASS: TestAptWriterURIDone (0.00s)
=== RUN   TestAptWriterFailURI
--- PASS: TestAptWriterFailURI (0.00s)
=== RUN   TestAptWriterFail
--- PASS: TestAptWriterFail (0.00s)
=== RUN   TestAptReaderReadMessage
--- PASS: TestAptReaderReadMessage (0.00s)
=== RUN   TestAptReaderParseHeader
--- PASS: TestAptReaderParseHeader (0.00s)
=== RUN   TestAptReaderParseHeaderFail
--- PASS: TestAptReaderParseHeaderFail (0.00s)
=== RUN   TestAptReaderParseField
--- PASS: TestAptReaderParseField (0.00s)
=== RUN   TestAptReaderParseFieldFail
--- PASS: TestAptReaderParseFieldFail (0.00s)
=== RUN   TestHandleConfigure
--- PASS: TestHandleConfigure (0.00s)
=== RUN   TestAptMethodRun
--- PASS: TestAptMethodRun (0.00s)
=== RUN   TestAptMethodRun404
--- PASS: TestAptMethodRun404 (0.00s)
=== RUN   TestAptMethodRun304
--- PASS: TestAptMethodRun304 (0.00s)
=== RUN   TestAptMethodRunFail
--- PASS: TestAptMethodRunFail (0.00s)
PASS
ok      github.com/GoogleCloudPlatform/artifact-registry-apt-transport/apt  0.026s
hopkiw commented 3 years ago

/test all

google-oss-robot commented 3 years ago

@hopkiw: No presubmit jobs available for GoogleCloudPlatform/artifact-registry-apt-transport@main

In response to [this](https://github.com/GoogleCloudPlatform/artifact-registry-apt-transport/pull/1#issuecomment-791746613): >/test all Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
hopkiw commented 3 years ago

oookay, we're still waiting on presubmits. here's this one then:

+>>> go test -v === RUN TestAptMessageGet --- PASS: TestAptMessageGet (0.00s) === RUN TestAptWriterWriteMessage --- PASS: TestAptWriterWriteMessage (0.00s) === RUN TestAptWriterSendCapabilities --- PASS: TestAptWriterSendCapabilities (0.00s) === RUN TestAptWriterLog --- PASS: TestAptWriterLog (0.00s) === RUN TestAptWriterURIStart --- PASS: TestAptWriterURIStart (0.00s) === RUN TestAptWriterURIDone --- PASS: TestAptWriterURIDone (0.00s) === RUN TestAptWriterFailURI --- PASS: TestAptWriterFailURI (0.00s) === RUN TestAptWriterFail --- PASS: TestAptWriterFail (0.00s) === RUN TestAptReaderReadMessage --- PASS: TestAptReaderReadMessage (0.00s) === RUN TestAptReaderParseHeader --- PASS: TestAptReaderParseHeader (0.00s) === RUN TestAptReaderParseHeaderFail --- PASS: TestAptReaderParseHeaderFail (0.00s) === RUN TestAptReaderParseField --- PASS: TestAptReaderParseField (0.00s) === RUN TestAptReaderParseFieldFail --- PASS: TestAptReaderParseFieldFail (0.00s) === RUN TestHandleConfigure --- PASS: TestHandleConfigure (0.00s) === RUN TestAptMethodRun --- PASS: TestAptMethodRun (0.00s) === RUN TestAptMethodRun404 --- PASS: TestAptMethodRun404 (0.00s) === RUN TestAptMethodRun304 --- PASS: TestAptMethodRun304 (0.00s) === RUN TestAptMethodRunFail --- PASS: TestAptMethodRunFail (0.00s) PASS ok github.com/GoogleCloudPlatform/artifact-registry-apt-transport/apt 0.026s

hopkiw commented 3 years ago

/test all

google-oss-robot commented 3 years ago

@hopkiw: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
prow/presubmit/gocheck 96186e84d5d66e210282e6fccf00cd428a66643a link /gocheck
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
hopkiw commented 3 years ago

fixed gocheck suggestions but ignoring the suggestion about stuttering, which I do not care about

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hopkiw, zoran15

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/artifact-registry-apt-transport/blob/main/OWNERS)~~ [hopkiw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment