GoogleCloudPlatform / artifact-registry-apt-transport

Apache License 2.0
9 stars 15 forks source link

Packaging #2

Closed hopkiw closed 3 years ago

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hopkiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/artifact-registry-apt-transport/blob/main/OWNERS)~~ [hopkiw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hopkiw commented 3 years ago

/packagebuild

hopkiw commented 3 years ago

/hold don't like where the conf snippet ends up

hopkiw commented 3 years ago

/packagebuild

hopkiw commented 3 years ago

this looks better:

$ dpkg-deb -I ./artifact-registry-apt-transport_1dummy-g1_amd64.deb ; dpkg-deb -c ./artifact-registry-apt-transport_1dummy-g1_amd64.deb 
 new Debian package, version 2.0.
 size 1769812 bytes: control archive=631 bytes.
      40 bytes,     1 lines      conffiles            
     497 bytes,    11 lines      control              
     253 bytes,     3 lines      md5sums              
 Package: artifact-registry-apt-transport
 Version: 1:1dummy-g1
 Architecture: amd64
 Maintainer: Google Cloud Team <gc-team@google.com>
 Installed-Size: 5498
 Section: misc
 Priority: optional
 Description: Artifact Registry Apt transport
  Contains an apt transport `ar+https` that can be used to configure
  authenticated access to your Artifact Registry package repository.
 Git: https://github.com/GoogleCloudPlatform/artifact-registry-apt-transport/tree/af1878f091d04e888dc5a8d2dccce4b1dc0403e6
drwxr-xr-x root/root         0 2021-03-09 16:43 ./
drwxr-xr-x root/root         0 2021-03-09 16:43 ./etc/
drwxr-xr-x root/root         0 2021-03-09 16:43 ./etc/apt/
drwxr-xr-x root/root         0 2021-03-09 16:43 ./etc/apt/apt.conf.d/
-rw-r--r-- root/root       545 2021-03-09 16:43 ./etc/apt/apt.conf.d/90artifact-registry
drwxr-xr-x root/root         0 2021-03-09 16:43 ./usr/
drwxr-xr-x root/root         0 2021-03-09 16:43 ./usr/lib/
drwxr-xr-x root/root         0 2021-03-09 16:43 ./usr/lib/apt/
drwxr-xr-x root/root         0 2021-03-09 16:43 ./usr/lib/apt/methods/
-rwxr-xr-x root/root   5612824 2021-03-09 16:43 ./usr/lib/apt/methods/ar+https
drwxr-xr-x root/root         0 2021-03-09 16:43 ./usr/share/
drwxr-xr-x root/root         0 2021-03-09 16:43 ./usr/share/doc/
drwxr-xr-x root/root         0 2021-03-09 16:43 ./usr/share/doc/artifact-registry-apt-transport/
-rw-r--r-- root/root       170 2021-03-09 16:43 ./usr/share/doc/artifact-registry-apt-transport/changelog.Debian.gz
-rw-r--r-- root/root       980 2021-03-09 16:43 ./usr/share/doc/artifact-registry-apt-transport/copyright
hopkiw commented 3 years ago

/unhold ready to review /assign illfelder

hopkiw commented 3 years ago

/hold

hopkiw commented 3 years ago

/packagebuild

illfelder commented 3 years ago

/lgtm

hopkiw commented 3 years ago

/packagebuild

hopkiw commented 3 years ago

finally:

dpkg-deb -I ./apt-transport-artifact-registry_1dummy-g1_amd64.deb; dpkg-deb -c ./apt-transport-artifact-registry_1dummy-g1_amd64.deb 
 new Debian package, version 2.0.
 size 1769588 bytes: control archive=632 bytes.
      40 bytes,     1 lines      conffiles            
     479 bytes,    11 lines      control              
     253 bytes,     3 lines      md5sums              
 Package: apt-transport-artifact-registry
 Version: 1:1dummy-g1
 Architecture: amd64
 Maintainer: Google Cloud Team <gc-team@google.com>
 Installed-Size: 5498
 Section: misc
 Priority: optional
 Description: Artifact Registry Apt transport
  Contains an apt transport that can be used to configure authenticated access
  to your Artifact Registry package repository.
 Git: https://github.com/GoogleCloudPlatform/artifact-registry-apt-transport/tree/4c82af5363ab1a5381ce47cae6317ff197de7e3c
drwxr-xr-x root/root         0 2021-03-09 17:25 ./
drwxr-xr-x root/root         0 2021-03-09 17:25 ./etc/
drwxr-xr-x root/root         0 2021-03-09 17:25 ./etc/apt/
drwxr-xr-x root/root         0 2021-03-09 17:25 ./etc/apt/apt.conf.d/
-rw-r--r-- root/root       538 2021-03-09 17:25 ./etc/apt/apt.conf.d/90artifact-registry
drwxr-xr-x root/root         0 2021-03-09 17:25 ./usr/
drwxr-xr-x root/root         0 2021-03-09 17:25 ./usr/lib/
drwxr-xr-x root/root         0 2021-03-09 17:25 ./usr/lib/apt/
drwxr-xr-x root/root         0 2021-03-09 17:25 ./usr/lib/apt/methods/
-rwxr-xr-x root/root   5612824 2021-03-09 17:25 ./usr/lib/apt/methods/ar+https
drwxr-xr-x root/root         0 2021-03-09 17:25 ./usr/share/
drwxr-xr-x root/root         0 2021-03-09 17:25 ./usr/share/doc/
drwxr-xr-x root/root         0 2021-03-09 17:25 ./usr/share/doc/apt-transport-artifact-registry/
-rw-r--r-- root/root       171 2021-03-09 17:25 ./usr/share/doc/apt-transport-artifact-registry/changelog.Debian.gz
-rw-r--r-- root/root       980 2021-03-09 17:25 ./usr/share/doc/apt-transport-artifact-registry/copyright
illfelder commented 3 years ago

/lgtm

hopkiw commented 3 years ago

/unhold