Closed adsr closed 3 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: adsr Once this PR has been reviewed and has the lgtm label, please assign bkatyl for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @adsr. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
- Exit clean on EOF instead of running forever
We observed this behavior today. If the process gets orphaned somehow, it busy loops reading EOF on stdin forever. Example:
user@host:~$ sudo strace -fvyyYtttT -p 1327075 2>&1
strace: Process 1327075 attached with 20 threads
...
[pid 1327087<ar+https>] 1710535486.854801 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000036>
[pid 1327087<ar+https>] 1710535486.854859 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000010>
[pid 1327087<ar+https>] 1710535486.854893 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000012>
[pid 1327087<ar+https>] 1710535486.854930 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000011>
[pid 1327087<ar+https>] 1710535486.854971 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000010>
[pid 1327087<ar+https>] 1710535486.855008 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000012>
[pid 1327087<ar+https>] 1710535486.855048 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000012>
[pid 1327087<ar+https>] 1710535486.855087 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000011>
[pid 1327087<ar+https>] 1710535486.855124 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000010>
[pid 1327087<ar+https>] 1710535486.855156 read(0<pipe:[157797980]>, "", 4096) = 0 <0.000010>
...
https://github.com/GoogleCloudPlatform/artifact-registry-apt-transport/pull/24 supersedes this one, and so this PR can now be closed; its changes have all been merged in. :)
I haven't found documentation on the apt transport protocol, so I'm just going by observed behavior of the built-in transports.
Make the following changes:
Debug::Acquire::gar
The http transport seems to consider an empty message an error, but given this case was already being handled specifically, I left it in.