search

GoogleCloudPlatform / artifact-registry-apt-transport

Apache License 2.0
10 stars 17 forks source link

Forked from adsr/debug_and_eof, pull request #21: finish responding to my own code review. #24

Closed ericdand closed 5 months ago

ericdand commented 5 months ago

@adsr deserves credit for the majority of this change; I just finished touching it up to address the feedback I had on his pull request, which appears to have been abandoned, but is a good change to check in nonetheless.

Along the way, I also properly formatted the TODO messages I saw to include an author name, per the Google style guide.

dorileo commented 5 months ago

/lgtm

dorileo commented 5 months ago

/approve

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dorileo, ericdand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/artifact-registry-apt-transport/blob/main/OWNERS)~~ [dorileo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment