Open rmohr opened 2 days ago
Hi @rmohr. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/approve
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ericdand, rmohr Once this PR has been reviewed and has the lgtm label, please assign bkatyl for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/lgtm
In case that apt is not sending over a
Config-Item
likeAcquire::gar::Service-Account-JSON
, the code falls back to default credential lookup.If it finds a metadata service, then it will automatically inherit the default
cloud-plaform
scope, but if it fins a service account json over theGOOGLE_APPLICATION_CREDENTIALS
environment variable, no scope will be requested, therefore always add the required AR scope explicitly.This fixes errors like
if the service account json is detected over the default credential lookup paths.