search

GoogleCloudPlatform / artifact-registry-apt-transport

Apache License 2.0
10 stars 17 forks source link

specify scope for JSON auth #3

Closed hopkiw closed 3 years ago

hopkiw commented 3 years ago

specify cloud-platform scope when initializing JSON credentials, leaving all permissions management at the IAM layer

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hopkiw, illfelder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/artifact-registry-apt-transport/blob/main/OWNERS)~~ [hopkiw,illfelder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-robot commented 3 years ago

New changes are detected. LGTM label has been removed.

google-oss-robot commented 3 years ago

@hopkiw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
prow/presubmit/gocheck 85078b1a329b94b969005e84a89a999620d5f25d link /gocheck
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).