Closed amilstead closed 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Hi @amilstead. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
CLA submitted. Sorry that wasn't done ahead of time.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: amilstead, hopkiw
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@amilstead Thanks for the PR, looks good. Can you update the tests for this change?
@amilstead Thanks for the PR, looks good. Can you update the tests for this change?
Sure! Will work on that sometime this week. Thanks!
Tests added-- I am by no means a go-expert, so please lmk if these tests are garbage or should be done differently.
@hopkiw just nudging here. Anything else I need to do?
Hi sorry, I just really don't have time to work on this. If someone else wants to pick up this PR and finish, please do.
All I can say is that this "works for me".
After looking at cloudflare's apt-transport that behaves very similarly it seems like a hard return is the right way to handle
EOF
andErrClosedPipe
errors coming from the reader.See here: https://github.com/cloudflare/apt-transport-cloudflared/blob/8fd3a7c4318a39b24d08b0fb62ed9983e1558aea/apt/method.go#L82-L85
Somewhat related; I needed this change plus a different binary name (see here) to get this transport to work under reprepro.