search

GoogleCloudPlatform / artifact-registry-go-tools

Apache License 2.0
7 stars 6 forks source link

Fix handling of NETRC environment variable in Load #19

Open eji opened 1 month ago

eji commented 1 month ago

The current Load implementation assumes NETRC environment variable is a directory.

However, other products like Go and Inetutils expect NETRC to be a file path. This discrepancy causes issues depending on usage.

Updated to allow artifact-registry-go-tools to work with NETRC as a file path.

Ensured backward compatibility so it still works if NETRC is a directory path.

yihanzhen commented 1 month ago

Oh embed was added after 1.15? 1.15 is too old anyway, would you mind removing 1.15 from the github action here: https://github.com/GoogleCloudPlatform/artifact-registry-go-tools/blob/main/.github/workflows/main.yml#L25?

eji commented 1 month ago

@yihanzhen I've removed Go 1.15 from the GitHub Action. Thanks for pointing that out! https://github.com/GoogleCloudPlatform/artifact-registry-go-tools/pull/19/commits/ccaaf6ab587834198d93eadc09aefcea40ecaca4