search

GoogleCloudPlatform / artifact-registry-maven-tools

Apache License 2.0
24 stars 22 forks source link

chore: update dependencies #56

Closed yihanzhen closed 3 years ago

yihanzhen commented 3 years ago

Update google-http-client and google-auth-library-oauth2-http to the latest version.

Also explicitly depend on jackson2 becuase google-auth-library-oauth2-http stopped depending on jackson2 after 0.16.2 so we loose it as a transitive dependency.

Fix #27 Fix #44

yihanzhen commented 3 years ago

/gcbrun

yihanzhen commented 3 years ago

/gcbrun

yihanzhen commented 3 years ago

/gcbrun

yihanzhen commented 3 years ago

/gcbrun

yihanzhen commented 3 years ago

@loosebazooka the latest version of google-auth-library-oauth2-http is 1.0.0 which is a major version update from 0.16.2; want to run through you to see if this is fine. Thanks!

chanseokoh commented 3 years ago

For our project, we occasionally have issues when upgrading Google HTTP libraries and had to fix bugs in them or revert upgrading. And last week, it happened, and we decided to downgrade them as there were issues one of which was critical. However, I think these issues only affect the Apache transport, which is what we use (with google-http-client-apache-v2). That is, you may be completely fine to upgrade if you're not using Apache.

We don't use google-auth-library-oauth2-http heavily in our code, so nothing to say about that. Just FYI, we went from google-auth-library-oauth2-http:0.18.0 to 1.0.0 and then back to 0.18.0 after downgrading.

yihanzhen commented 3 years ago

@chanseokoh thanks!

We don't use google-auth-library-oauth2-http heavily in our code, so nothing to say about that. Just FYI, we went from google-auth-library-oauth2-http:0.18.0 to 1.0.0 and then back to 0.18.0 after downgrading.

Is this because of something is off in google-auth-library-oauth2-http, or that is the version that works with the desired version of google-http-client-apache-v2?

chanseokoh commented 3 years ago

Is this because of something is off in google-auth-library-oauth2-http, or that is the version that works with the desired version of google-http-client-apache-v2?

I have been just mechanically following the combination defined by the java-shared-dependencies 2.0.1 BOM at that time when upgrading the HTTP libraries, hoping for the best compatibility. Nothing else.

antonshkurenko commented 3 years ago

Hi, when do you plan to release this?

yihanzhen commented 3 years ago

@tonyshkurenko 2.1.3 is published!

antonshkurenko commented 3 years ago

I'm not sure this PR changed something, but now this plugin relies on artifactregistry-auth-common:2.1.3, which is missing

A problem occurred configuring root project '***'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not find com.google.cloud.artifactregistry:artifactregistry-auth-common:2.1.3.

   Required by:
         project : > gradle.plugin.com.google.cloud.artifactregistry:artifactregistry-gradle-plugin:2.1.3

I can find it here, but there is no pom file: https://repo1.maven.org/maven2/com/google/cloud/artifactregistry/artifactregistry-auth-common/2.1.3/

CC: @yihanzhen @lindsayismith @chanseokoh

yihanzhen commented 3 years ago

@tonyshkurenko not sure what happened. I just republished 2.1.4 and the pom file is there: https://repo.maven.apache.org/maven2/com/google/cloud/artifactregistry/artifactregistry-auth-common/2.1.4/