search

GoogleCloudPlatform / artifact-registry-yum-plugin

Apache License 2.0
6 stars 13 forks source link

RSA vendor fixes #16

Closed hopkiw closed 3 years ago

hopkiw commented 3 years ago

Fixes issues in RSA vendoring.

Background:

We unfortunately must vendor rsa and other packages on EL8 RSA package doesn't use relative imports, so there are potential cyclic imports where import logic can't detect them, for example the reference in a method signature. Uses of imported names within code won't be evaluated at import time, but method signatures will. We were handling one such instance (getprime_func) by removing the init.py but this introduced some others Amend by pulling this one function out and restore init.py

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hopkiw, illfelder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/artifact-registry-yum-plugin/blob/main/OWNERS)~~ [hopkiw,illfelder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment