GoogleCloudPlatform / artifact-registry-yum-plugin

Apache License 2.0
6 stars 13 forks source link

Plugin no longer works, typo in ar-token #25

Open ziraldo-oanda opened 1 year ago

ziraldo-oanda commented 1 year ago

You have a typo in the options for ar-token.

https://github.com/GoogleCloudPlatform/artifact-registry-yum-plugin/blob/main/cmd/ar-token/main.go#L32

var (
    serviceAccountEmail = flag.String("service_acount_email", "",
        "Email of a service account to use on Google Compute Engine")
    serviceAccountJSON = flag.String("service_acount_json", "", "Path to a service account key in JSON format")
)

service_acount_email should be service_account_email. service_acount_json should be service_account_json.

These are being referenced by the dnf and yum plugins here:

lindsayismith commented 1 year ago

Leo can you find someone to take a look at this?

On Thu, Feb 16, 2023, 09:40 Andrew Ziraldo @.***> wrote:

You have a typo in the options for ar-token.

https://github.com/GoogleCloudPlatform/artifact-registry-yum-plugin/blob/main/cmd/ar-token/main.go#L32

var ( serviceAccountEmail = flag.String("service_acount_email", "", "Email of a service account to use on Google Compute Engine") serviceAccountJSON = flag.String("service_acount_json", "", "Path to a service account key in JSON format") )

service_acount_email should be service_account_email. service_acount_json should be service_account_json.

These are being referenced by the dnf and yum plugins here:

- https://github.com/GoogleCloudPlatform/artifact-registry-yum-plugin/blob/main/dnf/artifact-registry.py#L73

https://github.com/GoogleCloudPlatform/artifact-registry-yum-plugin/blob/main/yum/artifact-registry.py#L60

— Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/artifact-registry-yum-plugin/issues/25, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGA2TULKW2FNXJD6ZUXFV3WXZRBZANCNFSM6AAAAAAU6PBMOU . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>