search

GoogleCloudPlatform / artifact-registry-yum-plugin

Apache License 2.0
6 stars 13 forks source link

dnf: fix broken authorization for our gcp repositories #33

Closed dorileo closed 1 year ago

dorileo commented 1 year ago

repo.baseurl is not an actual string but a libdnf.module.VectorString and current implementation introduced with eef11a705a3318c7730c19b5dde6866a0296589c actually considers it as string. This patch makes sure to cast it to string before comparison.

ericdand commented 1 year ago

/approve

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dorileo, ericdand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/artifact-registry-yum-plugin/blob/main/OWNERS)~~ [dorileo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ericdand commented 1 year ago

/lgtm