search

GoogleCloudPlatform / artifact-registry-yum-plugin

Apache License 2.0
6 stars 14 forks source link

Prevent yum+dnf plugins from forwarding tokens without SSL. #35

Closed ericdand closed 1 year ago

ericdand commented 1 year ago

This change is in preparation of Artifact Registry supporting plain HTTP (no SSL) access under certain circumstances. Without this change, an eavesdropper might steal a token if a user has misconfigured their yum.conf file; this change will ensure that the plugin only activates for HTTPS connections.

dorileo commented 1 year ago

/lgtm

vorakl commented 1 year ago

/lgtm

vorakl commented 1 year ago

/approve

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericdand, vorakl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/artifact-registry-yum-plugin/blob/main/OWNERS)~~ [vorakl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment