GoogleCloudPlatform / artifact-registry-yum-plugin

Apache License 2.0
6 stars 14 forks source link

Vendor el8 dependencies #6

Closed hopkiw closed 3 years ago

hopkiw commented 3 years ago

On el8 more of the dependencies have to be vendored, including cachetools and rsa. Since there's no longer a simple transform command, move the packaging to use native sources and patches instead. The package build script will have to have a one line change to include these files in RPMDIR/SOURCES directory before invoking rpmbuild.

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hopkiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/artifact-registry-yum-plugin/blob/main/OWNERS)~~ [hopkiw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-robot commented 3 years ago

@hopkiw: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
prow/presubmit/packagebuild 324bd4014dbe65325d85b4bd9d8a06acc803cc40 link /packagebuild
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
hopkiw commented 3 years ago

package build is expected to fail for el7

illfelder commented 3 years ago

/lgtm