feat: handle deterministic URLs

GoogleCloudPlatform / avocano

Avocano is a sample dropship/fake product website, built with Firebase Hosting, Cloud Run, Cloud SQL and Cloud Build

https://avocano.web.app

Apache License 2.0

67 stars 31 forks source link

Closed glasnt closed 1 month ago

glasnt commented 1 month ago

Fixes #493

Changes CLOUDRUN_SERVICE_URL to support a list of URLs from the "run.googleapis.com/urls" annotation for CSRF.

Opted to not pluralise this URL, but update it to presume it's a string, with possible comma separation.

This also may not require run.viewer on the server service account any more, which will need to be updated with the tf updates.

NimJay commented 1 month ago

Sorry, I see that you ticked "Please merge this PR for me once it is approved", but I don't have permissions to merge.

glasnt commented 1 month ago

I added you to avocano-approvers ✨