Since we want to keep parity with the pre-v0.6.0 versions of Bank of Anthos which had each microservice in a different file, this causes some issues wherein duplicate Kubernetes objects are rendered in multiple files:
For release v0.6.0, I have taken the action of manually:
Removing the duplicate config.yaml objects from all other files
Removing the duplicate ledger-db.yaml and accounts-db.yaml objects from all other files
Removing the duplicate jwt-secret.yaml object from all other files
Adding the new ServiceAccount to the config.yaml file (not sure if it's the right place for it, it may deserve its own file, but that would require breaking a tutorial or two).
We should look into automating the above steps for new releases, or finding an alternative solution. I have looked into diff, comm, and third-party tools like dyff, but none of them works out great when diff'ing out entire objects.
As of release
v0.6.0
(PR: https://github.com/GoogleCloudPlatform/bank-of-anthos/pull/1425), release Kubernetes manifests are no longer copy-pasted from a staging directory. Instead, they are programmatically generated usingskaffold render
(see https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/release/v0.6.0/docs/releasing/make-release.sh#L60-L72).Since we want to keep parity with the pre-
v0.6.0
versions of Bank of Anthos which had each microservice in a different file, this causes some issues wherein duplicate Kubernetes objects are rendered in multiple files:For release
v0.6.0
, I have taken the action of manually:config.yaml
objects from all other filesledger-db.yaml
andaccounts-db.yaml
objects from all other filesjwt-secret.yaml
object from all other filesconfig.yaml
file (not sure if it's the right place for it, it may deserve its own file, but that would require breaking a tutorial or two).We should look into automating the above steps for new releases, or finding an alternative solution. I have looked into
diff
,comm
, and third-party tools likedyff
, but none of them works out great when diff'ing out entire objects.